rgw: s3website error handler uses original object name #20693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the s3website error handler needs to use the same object name for redirect handling that retarget() does, but s->object.name may be modified based on get_effective_key() Fixes: http://tracker.ceph.com/issues/23201 Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
Looks correct visually, I just need to refresh my memory on how AWS-S3 handles chains of redirections. |
robbat2
approved these changes
Mar 2, 2018
|
tested successfully against #20570: (unrelated failures from ragweed, multisite tests) |
oritwas
approved these changes
Mar 7, 2018
|
jewel backport - http://tracker.ceph.com/issues/23311 - looks non-trivial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the s3website error handler needs to use the same object name for redirect handling that
retarget()does, buts->object.namemay be modified based onget_effective_key()Fixes: http://tracker.ceph.com/issues/23201