Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang: define default value of LoglevelV only once (3 templates) #20727

Merged
merged 1 commit into from Mar 8, 2018

Conversation

mattbenjamin
Copy link
Contributor

I believe, after some searching, that this is a straightfoward
application of rule 14.1.12, C++14.

Signed-off-by: Matt Benjamin mbenjamin@redhat.com

@liewegas liewegas requested a review from rzarzynski March 5, 2018 22:05
@mattbenjamin mattbenjamin changed the title clang: define LoglevelV only once (3 templates) clang: define default value of LoglevelV only once (3 templates) Mar 5, 2018
I believe, after some searching, that this is a straightforward
application of rule 14.1.12, C++14.

Fixes compilation w/clang-5.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Copy link
Contributor

@rzarzynski rzarzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tchaikov
Copy link
Contributor

tchaikov commented Mar 8, 2018

http://pulpito.ceph.com/kchai-2018-03-08_12:59:37-rados-wip-kefu-testing-2018-03-08-1932-distro-basic-smithi/

@tchaikov tchaikov merged commit 0d5a33c into ceph:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants