Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang: define default value of LoglevelV only once (3 templates) #20727

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
3 participants
@mattbenjamin
Copy link
Contributor

commented Mar 5, 2018

I believe, after some searching, that this is a straightfoward
application of rule 14.1.12, C++14.

Signed-off-by: Matt Benjamin mbenjamin@redhat.com

@mattbenjamin mattbenjamin requested a review from tchaikov Mar 5, 2018

@liewegas liewegas requested a review from rzarzynski Mar 5, 2018

@mattbenjamin mattbenjamin changed the title clang: define LoglevelV only once (3 templates) clang: define default value of LoglevelV only once (3 templates) Mar 5, 2018

@mattbenjamin mattbenjamin force-pushed the linuxbox2:wip-clang-5 branch from d325799 to 63fedc6 Mar 5, 2018

clang: define default value for LoglevelV only once (3 templates)
I believe, after some searching, that this is a straightforward
application of rule 14.1.12, C++14.

Fixes compilation w/clang-5.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
@rzarzynski
Copy link
Contributor

left a comment

LGTM. Thanks!

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

http://pulpito.ceph.com/kchai-2018-03-08_12:59:37-rados-wip-kefu-testing-2018-03-08-1932-distro-basic-smithi/

  • the swift failure was caused by #20419
  • and i reran osd-pool-create.sh multiple times locally, and was not able to reproduce that failure.

@tchaikov tchaikov merged commit 0d5a33c into ceph:master Mar 8, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.