Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard v2: Add CSS class for required form fields #20747

Merged
merged 1 commit into from Mar 9, 2018

Conversation

votdev
Copy link
Member

@votdev votdev commented Mar 6, 2018

Developers should implement form fields that are required the following way:

<div class="form-group"
  <label i18n
         class="control-label col-sm-3"
         for="bucket">Name
    <span class="required"></span>  <----- Add this line
  </label>
  <div class="col-sm-9">
    <input id="bucket"
           name="bucket"
           class="form-control"
           formControlName="bucket">
    ...
  </div>
</div>

bildschirmfoto vom 2018-03-07 16-31-16

Signed-off-by: Volker Theile vtheile@suse.com

@votdev votdev added the DNM label Mar 7, 2018
@votdev votdev changed the title mgr/dashboard v2: Add cdRequired directive [DNM] mgr/dashboard v2: Add cdRequired directive Mar 7, 2018
@votdev votdev changed the title [DNM] mgr/dashboard v2: Add cdRequired directive mgr/dashboard v2: Add CSS class for required form fields Mar 7, 2018
@votdev votdev removed the DNM label Mar 7, 2018
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@votdev could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes

and could you squash these two commits into a single one? as you are reverting part of the first commit in the second one.

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev
Copy link
Member Author

votdev commented Mar 8, 2018

@tchaikov Fixed

Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - are there any input forms that could already be updated using this feature? Do you intend to take care of that in a separate PR?

@votdev
Copy link
Member Author

votdev commented Mar 8, 2018

@LenzGr No, there are currently no forms that must be updated. After merge each dev should be responsible for the forms he is implementing.

@rjfd rjfd merged commit 2a2847e into ceph:master Mar 9, 2018
@votdev votdev deleted the add_required_directive branch March 16, 2018 11:03
epuertat pushed a commit to rhcs-dashboard/ceph that referenced this pull request Jul 17, 2018
mgr/dashboard v2: Add CSS class for required form fields

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 2a2847e)
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
epuertat pushed a commit to rhcs-dashboard/ceph that referenced this pull request Jul 17, 2018
mgr/dashboard v2: Add CSS class for required form fields

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 2a2847e)
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants