New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard v2: Add CSS class for required form fields #20747
Conversation
5846edc
to
6eb46d5
Compare
6eb46d5
to
908f948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@votdev could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes
and could you squash these two commits into a single one? as you are reverting part of the first commit in the second one.
Signed-off-by: Volker Theile <vtheile@suse.com>
908f948
to
48fba11
Compare
@tchaikov Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - are there any input forms that could already be updated using this feature? Do you intend to take care of that in a separate PR?
@LenzGr No, there are currently no forms that must be updated. After merge each dev should be responsible for the forms he is implementing. |
mgr/dashboard v2: Add CSS class for required form fields Reviewed-by: Ricardo Marques <rimarques@suse.com> Reviewed-by: Lenz Grimmer <lgrimmer@suse.com> Reviewed-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 2a2847e) Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
mgr/dashboard v2: Add CSS class for required form fields Reviewed-by: Ricardo Marques <rimarques@suse.com> Reviewed-by: Lenz Grimmer <lgrimmer@suse.com> Reviewed-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 2a2847e) Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Developers should implement form fields that are required the following way:
Signed-off-by: Volker Theile vtheile@suse.com