mgr/dashboard_v2: Improve charts tooltips #20757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tspmelo
force-pushed
the
wip-chart-tooltip
branch
from
f07db1a
to
e219881
Compare
|
Modified the font-family used in the tooltips to match the old one. |
Devp00l
suggested changes
Mar 9, 2018
added 4 commits
March 12, 2018 14:50
Added a new scss and class for the tooltip. Signed-off-by: Tiago Melo <tmelo@suse.com>
Signed-off-by: Tiago Melo <tmelo@suse.com>
Signed-off-by: Tiago Melo <tmelo@suse.com>
Extracted the charts into a new component and it is now using a new tooltip. Signed-off-by: Tiago Melo <tmelo@suse.com>
tspmelo
force-pushed
the
wip-chart-tooltip
branch
from
e219881
to
ce4379b
Compare
|
votdev
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom tooltips to all the charts in the dashboard.
This will fix a current problem, where the tooltips would be cropped if its body was outside of the chart element (the original dashboard widgets had the same issue).
Old:
New:
