New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard_v2: Improve charts tooltips #20757

Merged
merged 4 commits into from Mar 13, 2018

Conversation

Projects
None yet
5 participants
@tspmelo
Copy link
Contributor

tspmelo commented Mar 6, 2018

This PR adds custom tooltips to all the charts in the dashboard.

This will fix a current problem, where the tooltips would be cropped if its body was outside of the chart element (the original dashboard widgets had the same issue).

Old:
image image image

New:
image image image

@tspmelo tspmelo added the dashboard label Mar 6, 2018

@tspmelo tspmelo force-pushed the tspmelo:wip-chart-tooltip branch from f07db1a to e219881 Mar 7, 2018

@tspmelo

This comment has been minimized.

Copy link
Contributor Author

tspmelo commented Mar 7, 2018

Modified the font-family used in the tooltips to match the old one.

@tspmelo tspmelo requested review from ricardoasmarques , Devp00l and votdev Mar 9, 2018

@Devp00l
Copy link
Contributor

Devp00l left a comment

Please add more type declarations to your code.

@ricardoasmarques
Copy link
Member

ricardoasmarques left a comment

lgtm

tspmelo added some commits Feb 28, 2018

mgr/dashboard_v2: improve tooltip of cdSparkline
Added a new scss and class for the tooltip.

Signed-off-by: Tiago Melo <tmelo@suse.com>
mgr/dashboard_v2: extract cephfs chart into a component
Signed-off-by: Tiago Melo <tmelo@suse.com>
mgr/dashboard_v2: improve health page charts tooltips
Extracted the charts into a new component and it is now using a new tooltip.

Signed-off-by: Tiago Melo <tmelo@suse.com>
mgr/dashboard_v2: improve tooltip of cephfsChart
Signed-off-by: Tiago Melo <tmelo@suse.com>

@tspmelo tspmelo force-pushed the tspmelo:wip-chart-tooltip branch from e219881 to ce4379b Mar 12, 2018

@tspmelo

This comment has been minimized.

Copy link
Contributor Author

tspmelo commented Mar 12, 2018

  • Fixed a problem in the calculation of the top position on sparkline charts.
  • added some types.
  • Remove 2 unused vars.
@votdev

votdev approved these changes Mar 12, 2018

@Devp00l
Copy link
Contributor

Devp00l left a comment

lgtm

@LenzGr LenzGr merged commit be113e3 into ceph:master Mar 13, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tspmelo tspmelo deleted the tspmelo:wip-chart-tooltip branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment