pybind/mgr/balancer: two more fixes #20788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@liewegas Yet another balancer-fix against ZeroDivisionError |
We don't care about the values here. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
To avoid crashes as below:
```
File "/usr/lib/ceph/mgr/balancer/module.py", line 181, in calc_stats
score += target[k] * (math.erf(((adjusted - avg)/avg) / math.sqrt(2.0)))
ZeroDivisionError: float division by zero
```
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
wip-balancer-04
branch
from
c08fbcc
to
1e3498a
Compare
liewegas
approved these changes
Mar 8, 2018
|
@tchaikov Thanks! |
|
@xiexingguo i guess your fixes for balancer also apply to luminous. do you think it's worthwhile to backport them? |
@tchaikov I did backport them. See #20359 (because these new fixes relies on that PR too) 😂 |
|
@xiexingguo wow, great! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.