Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind/mgr/balancer: two more fixes #20788

Merged
merged 3 commits into from Mar 9, 2018

Conversation

Projects
None yet
3 participants
@xiexingguo
Copy link
Member

commented Mar 8, 2018

No description provided.

pybind/mgr/balancer: skip out/crush-out osds
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@xiexingguo xiexingguo requested a review from liewegas Mar 8, 2018

@xiexingguo

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2018

@liewegas Yet another balancer-fix against ZeroDivisionError

xiexingguo added some commits Mar 7, 2018

pybind/mgr/balancer: s/iteritems/iterkeys/
We don't care about the values here.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
pybind/mgr/balancer: sanity check against empty roots
To avoid crashes as below:
```
File "/usr/lib/ceph/mgr/balancer/module.py", line 181, in calc_stats
    score += target[k] * (math.erf(((adjusted - avg)/avg) / math.sqrt(2.0)))
ZeroDivisionError: float division by zero
```

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@xiexingguo xiexingguo force-pushed the xiexingguo:wip-balancer-04 branch from c08fbcc to 1e3498a Mar 8, 2018

@tchaikov tchaikov merged commit 8426e1b into ceph:master Mar 9, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
@xiexingguo

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2018

@tchaikov Thanks!

@xiexingguo xiexingguo deleted the xiexingguo:wip-balancer-04 branch Mar 10, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2018

@xiexingguo i guess your fixes for balancer also apply to luminous. do you think it's worthwhile to backport them?

@xiexingguo

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2018

@xiexingguo i guess your fixes for balancer also apply to luminous. do you think it's worthwhile to backport them?

@tchaikov I did backport them. See #20359 (because these new fixes relies on that PR too) 😂

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2018

@xiexingguo wow, great! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.