Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon: node ls improvement #20820

Merged
merged 1 commit into from Apr 2, 2018
Merged

mon: node ls improvement #20820

merged 1 commit into from Apr 2, 2018

Conversation

guzhongyan
Copy link
Contributor

output mon/mds name instead of their rank

Signed-off-by: Gu Zhongyan guzhongyan@360.cn

@guzhongyan
mon: node ls improvement
fcc84ed 
output mon/mds name instead of their rank

Signed-off-by: Gu Zhongyan <guzhongyan@360.cn>
@guzhongyan
Copy link
Contributor Author

daemon name could be more useful than rank, detailed discussion here:
#20711 (comment)

@jcsp jcsp added the mon label Mar 13, 2018
@guzhongyan
Copy link
Contributor Author

@jcsp @tchaikov take a look?

jcsp
jcsp approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@jcsp jcsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jcsp
Copy link
Contributor

jcsp commented Mar 15, 2018

retest this please (jenkins)

@tchaikov
Copy link
Contributor

tchaikov commented Apr 2, 2018

@tchaikov tchaikov merged commit 6a981eb into ceph:master Apr 2, 2018
@guzhongyan guzhongyan deleted the nodels-improve branch April 11, 2018 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcsp jcsp jcsp approved these changes

Assignees
No one assigned
Labels
mon needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
3 participants
@guzhongyan @jcsp @tchaikov