ceph-volume process the abspath of the executable first #20824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test ceph-volume all |
andrewschoen
approved these changes
Mar 12, 2018
alfredodeza
force-pushed
the
wip-rm23259
branch
from
1623b42
to
8c4a686
Compare
So that it can always log the full path to the executable when it is logging the 'Running command:' line Signed-off-by: Alfredo Deza <adeza@redhat.com>
alfredodeza
force-pushed
the
wip-rm23259
branch
from
8c4a686
to
8d4b005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it can always log the full path to the executable when it is
logging the 'Running command:' line
The tracker ticket is a bit misleading, because the output in ceph-volume would show:
Giving the false impression the some executables aren't found, but the thing is that the logging of the command might omit the resolving of the absolute path.
Fixes http://tracker.ceph.com/issues/23259