rgw_file: conditionally unlink handles when direct deleted #20834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deadlock fix in 3cf0880 deals correctly deals with the recycle-path locking, but incorrectly removed handle table cleanup in the !recycle-path case. The conditional handle removal is predicated on not being in the recycle path, so this cannot deadlock. Fixes: http://tracker.ceph.com/issues/23299 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
cbodley
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deadlock fix in 3cf0880 deals correctly deals with the
recycle-path locking, but incorrectly removed handle table cleanup
in the !recycle-path case.
The conditional handle removal is predicated on not being in the
recycle path, so this cannot deadlock.
Fixes: http://tracker.ceph.com/issues/23299
Signed-off-by: Matt Benjamin mbenjamin@redhat.com