Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: OSDMonitor: limit tier-specific pool set/get on non-tier pools #2086

Merged
merged 9 commits into from Jul 11, 2014

Conversation

jecluis
Copy link
Member

@jecluis jecluis commented Jul 9, 2014

Fixes: 8696

Also has a few other patches addressing some miscelaneous stuff such as:

  • make sure to clear tier-specific fields from pg_pool_t when removing a tier
  • be really verbose on inconsistency when removing a tier
  • some workunits for all of the above
  • some fixes on qa/workunits/cephtool/test.sh for those tests that were setting
    and getting some tier-specific variables on non-tier pools.

@jecluis
Copy link
Member Author

jecluis commented Jul 9, 2014

This hasn't gone through the gitbuilders yet and while I did run cephtool/test.sh on my local machine I didn't run make check.

@liewegas
Copy link
Member

Looks like they failed on the gitbuilders

Joao Eduardo Luis added 9 commits July 11, 2014 00:17
Fixes: 8696

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
We may not crash your cluster, but you'll know that this is not something
that should have happened.  Big letters makes it obvious.  We'd make them
red too if we bothered to look for the ANSI code.

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Make sure gets and sets of tiering-specific variables succeed on tier
pools and fail on non-tier pools.

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
liewegas pushed a commit that referenced this pull request Jul 11, 2014
mon: OSDMonitor: limit tier-specific pool set/get on non-tier pools

Reviewed-by: Sage Weil <sage@redhat.com>
@liewegas liewegas merged commit 1fd89ce into master Jul 11, 2014
@liewegas liewegas deleted the wip-8696 branch July 11, 2014 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants