Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include: kill MIN and MAX macros #20886

Merged
merged 2 commits into from Mar 15, 2018
Merged

include: kill MIN and MAX macros #20886

merged 2 commits into from Mar 15, 2018

Conversation

liewegas
Copy link
Member

No description provided.

@liewegas
osd/PrimaryLogPG: MIN -> std::min
abc4be4 
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas
include: kill MIN and MAX macros
9e35e73 
Use std::min and std::max instead.

Signed-off-by: Sage Weil <sage@redhat.com>
gregsfortytwo
gregsfortytwo approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@gregsfortytwo gregsfortytwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Greg Farnum gfarnum@redhat.com

@tchaikov
Copy link
Contributor

http://pulpito.ceph.com/kchai-2018-03-14_04:42:43-rados-wip-kefu-testing-2018-03-14-1106-distro-basic-mira/

@tchaikov tchaikov merged commit 5002840 into ceph:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsfortytwo gregsfortytwo gregsfortytwo approved these changes

@adamemerson adamemerson Awaiting requested review from adamemerson

Assignees
No one assigned
Labels
cleanup core wip-kefu-testing
Projects
None yet
Milestone
No milestone
3 participants
@liewegas @tchaikov @gregsfortytwo