Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr: fix MSG_MGR_MAP handling #20892

Merged
merged 1 commit into from Mar 16, 2018
Merged

mgr: fix MSG_MGR_MAP handling #20892

merged 1 commit into from Mar 16, 2018

Conversation

guzhongyan
Copy link
Contributor

ceph config show mgr.x doesn't work
root cause is mgr daemon's mgrc has no chance
to process MSG_MGR_MAP in the mgr daemon's
ms_dispatch.

fix is let this message pass through for mgrc

Signed-off-by: Gu Zhongyan guzhongyan@360.cn
Signed-off-by: yupeng chen chenyupeng-it@360.cn

@guzhongyan
mgr: fix MSG_MGR_MAP handling
f04190e 
ceph config show mgr.x doesn't work
root cause is mgr daemon's mgrc has no chance
to process MSG_MGR_MAP in the mgr daemon's
ms_dispatch.

fix is let this message pass through for mgrc

Signed-off-by: Gu Zhongyan <guzhongyan@360.cn>
Signed-off-by: yupeng chen chenyupeng-it@360.cn
@guzhongyan
Copy link
Contributor Author

guzhongyan commented Mar 14, 2018 •
edited

after the fix, output looks good.
$ceph config show mgr.x

NAME VALUE SOURCE OVERRIDES IGNORES
admin_socket /tmp/ceph-asok.JKFfz8/$name.asok file
auth_client_required none file
auth_cluster_required none file
auth_service_required none file
chdir file
debug_mgrc 20/20 file
enable_experimental_unrecoverable_data_corrupting_features * file
erasure_code_dir /home/guzhongyan/ceph-dashv2/ceph/build/lib file
filestore_fd_cache_size 32 file
heartbeat_file /home/guzhongyan/ceph-dashv2/ceph/build/out/$name.heartbeat file
keyring $mgr_data/keyring default
lockdep true file
log_file /home/guzhongyan/ceph-dashv2/ceph/build/out/$name.log file
mgr_data /home/guzhongyan/ceph-dashv2/ceph/build/dev/mgr.$id file
mgr_module_path /home/guzhongyan/ceph-dashv2/ceph/src/pybind/mgr file
mon_osd_backfillfull_ratio 0.990000 file
mon_osd_full_ratio 0.990000 file
mon_osd_nearfull_ratio 0.990000 file
mon_pg_warn_min_per_osd 3 mon
osd_crush_chooseleaf_type 0 file
osd_failsafe_full_ratio 0.990000 file
osd_pool_default_min_size 1 mon
osd_pool_default_size 3 mon
pid_file /home/guzhongyan/ceph-dashv2/ceph/build/out/mgr.x.pid cmdline file
plugin_dir /home/guzhongyan/ceph-dashv2/ceph/build/lib file
rbd_default_features 61 default
run_dir /home/guzhongyan/ceph-dashv2/ceph/build/out file
setgroup ceph cmdline
setuser ceph cmdline

@jcsp
Copy link
Contributor

jcsp commented Mar 14, 2018

Thanks for the fix, please could you open a ticket on tracker.ceph.com and add a "Fixes: " line to this commit message, so that we can track it more easily for backport?

@guzhongyan
Copy link
Contributor Author

Fix tracker added:
http://tracker.ceph.com/issues/23368

@tchaikov
Copy link
Contributor

http://pulpito.ceph.com/kchai-2018-03-15_09:01:45-rados-wip-kefu-testing-2018-03-15-1505-distro-basic-smithi/

this change should be merged along with #20916

@tchaikov
Copy link
Contributor

@tchaikov tchaikov merged commit f836de6 into ceph:master Mar 16, 2018
@guzhongyan guzhongyan deleted the fix-mgrc branch March 19, 2018 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcsp jcsp jcsp approved these changes

Assignees
No one assigned
Labels
bug-fix mgr wip-kefu-testing
Projects
None yet
Milestone
No milestone
3 participants
@guzhongyan @jcsp @tchaikov