os/bluestore: do SSD discard on mkfs #20897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
reviewed
Mar 14, 2018
src/os/bluestore/BlueStore.cc
Outdated
| @@ -4316,7 +4316,7 @@ int BlueStore::_open_bdev(bool create) | |||
| assert(bdev == NULL); | |||
| string p = path + "/block"; | |||
| bdev = BlockDevice::create(cct, p, aio_cb, static_cast<void*>(this), discard_cb, static_cast<void*>(this)); | |||
| int r = bdev->open(p); | |||
| int r = bdev->open(p, create); | |||
There was a problem hiding this comment.
I think it would be easier/cleaner to just add an if (discard_on_create) bdev->discard(...) after the three open() calls in _open_bdev(). A "create" mode on block device open feels like an awkward interface to me.
ifed01
force-pushed
the
wip-ifed-discard-on-mkfs
branch
3 times, most recently
from
18f58e0
to
b40850c
Compare
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
ifed01
force-pushed
the
wip-ifed-discard-on-mkfs
branch
from
b40850c
to
f3be110
Compare
|
@liewegas - updated |
liewegas
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Fedotov ifedotov@suse.com