Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Adds reusable deletion dialog #20899

Merged
merged 5 commits into from Apr 24, 2018
Merged

mgr/dashboard: Adds reusable deletion dialog #20899

merged 5 commits into from Apr 24, 2018

Commits on Apr 24, 2018

  1. mgr/dashboard: Add modal component 

    This component should be used each time you define a new modal.
This will allows us to keep all modals with the same visual aspect.

Signed-off-by: Tiago Melo <tmelo@suse.com>
Signed-off-by: Stephan Müller <smueller@suse.com>
    Tiago Melo authored and Stephan Müller committed Apr 24, 2018
    Copy the full SHA
    f1c2f91 View commit details
    Browse the repository at this point in the history

  2. mgr/dashboard: Adds reusable deletion dialog 

    You can now simply use a deletion dialog without having to import a lot
of different things from ngx-bootstrap. Its easy to extend the dialog
by a detail description.

Signed-off-by: Tiago Melo <tmelo@suse.com>
Signed-off-by: Stephan Müller <smueller@suse.com>
    Stephan Müller committed Apr 24, 2018
    Copy the full SHA
    33e7533 View commit details
    Browse the repository at this point in the history

  3. mgr/dashboard: Changes deletion button to link 

    This change was made because a link can be placed anywhere instead of a
button element.

Signed-off-by: Stephan Müller <smueller@suse.com>
    Stephan Müller committed Apr 24, 2018
    Copy the full SHA
    f2096e9 View commit details
    Browse the repository at this point in the history

  4. mgr/dashboard: Change deletion link to modal only 

    Due to CSS problems the link solution wasn't the best way, now it will
represent only the modal content. The downside of this solution is that
it put's the burden on the developer to use it the right way and import
a view things to get it working. But on the upside CSS styles will work
as expected.

The unit test example was updated accordingly this way it should be easy
to understand how it can be implemented the right way.

Signed-off-by: Stephan Müller <smueller@suse.com>
    Stephan Müller committed Apr 24, 2018
    Copy the full SHA
    63ae858 View commit details
    Browse the repository at this point in the history

  5. mgr/dashboard: Replaces delete-confirmation-modal 

    This replaces usage of "delete-confirmation-modal" with the use of
"delete-modal".

Signed-off-by: Stephan Müller <smueller@suse.com>
    Stephan Müller committed Apr 24, 2018
    Copy the full SHA
    d110eba View commit details
    Browse the repository at this point in the history