mgr/dashboard: Add ErasureCodeProfile controller #20920
Conversation
| return ret | ||
|
|
||
| @RESTController.args_from_json | ||
| def create(self, name, k, m, ruleset_failure_domain=None): |
There was a problem hiding this comment.
what about allowing the caller to specify the plugin to the be used?
There was a problem hiding this comment.
I agree, this was something that was brought up in a conversation I had today. Being able to provide the plugin would be nice, but then we would also need a method that returns a list of available plugins, so we don't have to maintain a hard-coded list. Not sure if that exists, though. We had similar issues with providing a selection list for compression plugins in openATTIC where we maintained a static list, but the actual build of Ceph may have been compiled with different defaults.
| if ruleset_failure_domain: | ||
| profile.append('crush-failure-domain={}'.format(ruleset_failure_domain)) | ||
|
|
||
| CephService.send_command('mon', 'osd erasure-code-profile set', name=name, |
There was a problem hiding this comment.
how is the potential errors of this call being handled?
There was a problem hiding this comment.
Error handling will change as soon as the task manager form @rjfd is merged. Right now, an exception is thrown and cached by the general exception handler which will render a JSON error containing an error message.
|
@sebastian-philipp can you please add a bit more detail in the PR's description about what this PR implements? |
LenzGr
changed the title
sebastian-philipp
force-pushed
the
dashboard_v2-erasure-code-profile
branch
from
fec1dd1
to
eedc1f1
Compare
sebastian-philipp
changed the title
sebastian-philipp
force-pushed
the
dashboard_v2-erasure-code-profile
branch
2 times, most recently
from
cd6f732
to
1ed3bcd
Compare
|
retest this please |
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
As needed by the UI. Signed-off-by: Stephan Müller <smueller@suse.com>
sebastian-philipp
force-pushed
the
dashboard_v2-erasure-code-profile
branch
from
1ed3bcd
to
c60da7b
Compare
|
Just updated this PR to the latest master. @Devp00l please retest. |
|
jenkins retest this please |
This PR is part of backend implementation of the create-pool dialog. It is related to PR #20865 but not a dependency of it. Part of the Create-Pool-Dialog is a sub-dialog to manage ECPs.
TODO:
defaultare inaccessible #20976Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
I've also added a commit made by @Devp00l to fix an issue with the pool creation dialog.