osd/OSDMap: fix HAVE_FEATURE logic in encode() #20922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently clients that don't have SERVER_LUMINOUS end up being fed v6 (i.e. luminous) encoding because they also don't have SERVER_MIMIC. This was introduced in commit 553048f ("osd/OSDMap: track newly removed and purged snaps in each epoch"). Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
liewegas
approved these changes
Mar 15, 2018
|
Yikes, this LGTM too. Do we think the right pattern here is just to use “else if” statements as in this PR, or is there some other kind of meta-structure we can use that looks more different when correct? |
|
i think else if is fine. i'm worried there are other cases like this we missed. checking my peering branch now! |
|
I have checked master before submitting this PR, nothing else caught my eye. |
|
yeah i don't see anything either. 👍 |
|
krbd test case on a 4.4 kernel, good to merge from the kernel client perspective: http://pulpito.ceph.com/dis-2018-03-15_18:48:40-krbd-wip-osdmap-encoding-fix-distro-basic-smithi/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently clients that don't have SERVER_LUMINOUS end up being fed
v6 (i.e. luminous) encoding because they also don't have SERVER_MIMIC.
This was introduced in commit 553048f ("osd/OSDMap: track newly
removed and purged snaps in each epoch").
Signed-off-by: Ilya Dryomov idryomov@gmail.com