os/bluestore: free the spdk qpair resource correctly in destructor of SharedDriverQueueData #20929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Mar 16, 2018
src/os/bluestore/NVMEDevice.cc
Outdated
| spdk_nvme_ctrlr_free_io_qpair(qpair); | ||
| bdev->queue_number--; | ||
| qpair = NULL; |
There was a problem hiding this comment.
this line is not necessary.
There was a problem hiding this comment.
@JianyuLi this is not addressed.
|
could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes |
|
retest this please |
… SharedDriverQueueData Signed-off-by: Jianyu Li <joannyli@foxmail.com>
|
@JianyuLi ping? |
JianyuLi
force-pushed
the
joa-bluestore-spdk
branch
from
185f17c
to
45b6dc9
Compare
|
update the commit message as requested, please have a look. |
|
@JianyuLi please fold these two commits into a single one. |
|
Done, remove the unnecessary qpair reset. |
JianyuLi
force-pushed
the
joa-bluestore-spdk
branch
from
04c6866
to
291de35
Compare
|
@tchaikov ,merged the two commit. |
tchaikov
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ‘if (!qpair)’ condition wouldn't free spdk qpair resource in destructor of SharedDriverQueueData
Signed-off-by: Jianyu Li joannyli@foxmail.com