mgr/dashboard: additional fixes to block pages #20941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dillaman this is great! Thanks for fixing the iSCSI part of the dashboard. |
|
Indeed - thanks a lot for your help! |
|
no worries |
ricardoasmarques
approved these changes
Mar 16, 2018
| @@ -1,5 +1,6 @@ | |||
| import { Component } from '@angular/core'; | |||
|
|
|||
| import { CellTemplate } from '../../../shared/enum/cell-template.enum'; | |||
| import { CephShortVersionPipe } from '../../../shared/pipes/ceph-short-version.pipe'; | |||
| import { DimlessBinaryPipe } from '../../../shared/pipes/dimless-binary.pipe'; | |||
There was a problem hiding this comment.
Now that we are no longer using the dimlessBinaryPipe in this file, we can remove this import and the corresponding line on the class constructor (line 25).
added 3 commits
March 16, 2018 14:16
Label rates w/ "/s" suffix and switch throughput back to the sparkline graph from dashboard v1. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-dashboard-rbd
branch
from
02f920b
to
875f0bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.