mon/PGMap: remove or narrow columns 'pg ls' output #20945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timestamps are more informative. Signed-off-by: Sage Weil <sage@redhat.com>
Degraded and misplaces are the more useful values (and the heading was too wide!). Signed-off-by: Sage Weil <sage@redhat.com>
|
Having two "PRI" columns with the same name is a bit weird, I wonder if we could remove the need for those columns at all with a convention that the OSDs in the UP and ACTING columns always have the primary first, if they don't already? |
|
It's normally true for replicated PGs, but not for EC ones. The operator<< in the OSD debug code print something like "[1,2,3]p2" (for ec pool soly)... we could use the same syntax here and stick it in the up/acting columns? It's a bit less clean but more compact. |
|
Since this output is already pretty low level stuff, that compact form should be a good fit. If we have two columns with the same name there is a risk it might bug me forever :-D |
Signed-off-by: Sage Weil <sage@redhat.com>
e.g., "[1,2,3]p1". This matches what PG's operator<< does in the OSD debug log, with the exception that the OSD leaves off the 'p123' bit on replicated pools (which currently always make the first acting osd the primary). Leaving it on here to be explicit and a bit future-proof. Signed-off-by: Sage Weil <sage@redhat.com>
|
retest this please |
|
@jcsp ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the removals are uncontroversial.
I'm not sure about the duplicate PRI columns, though. Perhaps we don't need up_primary at all?