Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mgr/dashboard.rst: mention ceph.conf and ceph mgr services #20961

Merged
merged 3 commits into from Mar 28, 2018

Conversation

smithfarm
Copy link
Contributor

Also break down the "Configuration" section into three separate sub-sections
for clarity.

Signed-off-by: Nathan Cutler ncutler@suse.com

@@ -74,6 +89,9 @@ will be stored in the MON's configuration database::
The password will be stored in the configuration database in encrypted form
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly, the command two lines before this comment is wrong. But I'm not sure what the correct version is. Maybe this?

ceph tell mgr.\* set-login-credentials <username> <password>

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ceph mgr dashboard set-login-credentials <username> <password> - added a commit to fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smithfarm somehow I don't seem to see this last commit in the current PR. Did you push it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LenzGr I removed the commit because the command currently in the file ceph dashboard set-login-credentials <username> <password> is correct. The problem was I couldn't get the command to work for me, due to a bug since fixed by @rjfd.

In order to be able to log in, you need to define a username and password, which
will be stored in the MON's configuration database::

ceph dashboard set-login-credentials <username> <password>
ceph mgr dashboard set-login-credentials <username> <password>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the mgr part. The command was already correct!

@smithfarm
Copy link
Contributor Author

@rjfd Removed the defective commit. I was confused by http://tracker.ceph.com/issues/23404 and http://tracker.ceph.com/issues/23406

Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Also break down the "Configuration" section into three separate sub-sections
for clarity.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor Author

@LenzGr I hadn't merged this yet because I wanted to mention that mgr initial modules can take multiple modules in a space-separated list. Added a commit to reflect that.

@LenzGr
Copy link
Contributor

LenzGr commented Mar 27, 2018

jenkins render docs

@ceph-jenkins
Copy link
Collaborator

Doc render available at http://docs.ceph.com/ceph-prs/20961/

@@ -74,6 +95,9 @@ will be stored in the MON's configuration database::
The password will be stored in the configuration database in encrypted form
using ``bcrypt``. This is a global setting that applies to all dashboard instances.

Accessing the dashboard
^^^^^^^^^^^^^^^^^^^^^^^

You can now access the dashboard using your (JavaScript-enabled) web browser, by
pointing it to the selected TCP port and any of the host names or IP addresses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found one minor room for improvement: could you put "TCP port" after "host names or IP addresses", so it reads as follows: "...pointing it to any of the host names or IP addresses and the selected TCP port..." (this would spare me from opening a separate PR in order to fix that). Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LenzGr OK, added a commit to address this.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@LenzGr LenzGr merged commit 5a65671 into ceph:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants