Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Improve npm start script #20989

Merged
merged 2 commits into from Mar 22, 2018

Conversation

ricardoasmarques
Copy link
Contributor

Currently the vstart cluster will fail to start after we execute npm start during the frontend development, because ng serve deletes the frontend assets directory.

This PR will prevent ng serve fom deleting the dist directory and also simplify the npm start comand

Signed-off-by: Ricardo Marques <rimarques@suse.com>
Signed-off-by: Ricardo Marques <rimarques@suse.com>
@ricardoasmarques ricardoasmarques changed the title mgd/dashboard: Improve npm start mgd/dashboard: Improve npm start script Mar 21, 2018
@ricardoasmarques ricardoasmarques changed the title mgd/dashboard: Improve npm start script mgr/dashboard: Improve npm start script Mar 21, 2018
Copy link
Contributor

@tspmelo tspmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rjfd rjfd merged commit ebd7879 into ceph:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants