Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/ops: setup-virtualenv.sh: do not hardcode python binary #21002

Merged
merged 5 commits into from Mar 23, 2018
Merged

build/ops: setup-virtualenv.sh: do not hardcode python binary #21002

merged 5 commits into from Mar 23, 2018

Conversation

smithfarm
Copy link
Contributor

Part of the ongoing Python 3 enablement.

@smithfarm smithfarm added the DNM label Mar 22, 2018
@smithfarm
tools: setup-virtualenv.sh: do not hardcode python binary
a4fd5c4 
. . . instead, take a command-line option that defaults to
"python2.7"

Fixes: http://tracker.ceph.com/issues/23437
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
build/ops: declare python version when calling setup-virtualenv.sh
9f970f9 
This just makes the current Python 2.7 dependency explicit. Making
these statements optionally use Python 3 is left for later.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
tools: setup-virtualenv.sh: check for mandatory argument
0809901 
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
tools: setup-virtualenv.sh: add usage function and --help option
2a93474 
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
tools: setup-virtualenv.sh: improve error message
de2f71a 
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor Author

Changelog:

  • fixed broken options processing
  • added usage function
  • added --help option
  • script now fails with an error message if mandatory argument is missing

@smithfarm smithfarm removed the DNM label Mar 23, 2018
tspmelo
tspmelo approved these changes Mar 23, 2018
View reviewed changes
Copy link
Contributor

@tspmelo tspmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the dashboard related code and it works.

@smithfarm
Copy link
Contributor Author

smithfarm commented Mar 23, 2018 •
edited

https://shaman.ceph.com/builds/ceph/wip-smithfarm-testing/4902769c7cc940ecf53bac18511cb5b568be77e7/

http://pulpito.ceph.com/smithfarm-2018-03-23_16:16:12-rados-wip-smithfarm-testing-distro-basic-smithi/

rjfd
rjfd approved these changes Mar 23, 2018
View reviewed changes
Copy link
Contributor

@rjfd rjfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smithfarm smithfarm merged commit 235f211 into ceph:master Mar 23, 2018
@smithfarm smithfarm deleted the wip-23437 branch March 23, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tspmelo tspmelo tspmelo approved these changes

@jcsp jcsp jcsp approved these changes

@rjfd rjfd rjfd approved these changes

@tchaikov tchaikov Awaiting requested review from tchaikov

Assignees
No one assigned
Labels
build/ops wip-smithfarm-testing
Projects
None yet
Milestone
No milestone
4 participants
@smithfarm @tspmelo @jcsp @rjfd