mgr/dashboard: skip data pool testcase for none-bluestore clusters #21004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0nea
requested review from
LenzGr,
jcsp,
votdev,
sebastian-philipp,
p-se,
ricardoasmarques and
rjfd
sebastian-philipp
suggested changes
Mar 22, 2018
qa/tasks/ceph_manager.py
Outdated
| out = self.raw_cluster_cmd('osd', 'metadata', '--format=json') | ||
| return json.loads('\n'.join(out.split('\n')[1:])) | ||
|
|
||
| def get_osd_metadata(self): |
There was a problem hiding this comment.
Can we delete this method and rename get_osd_metadata_json to get_osd_metadata?
| for osd in osd_metadata: | ||
| if osd['osd_objectstore'] != 'bluestore': | ||
| cls.bluestore_support = False | ||
| break |
There was a problem hiding this comment.
Interestingly, this is very similar to https://github.com/ceph/ceph/pull/20865/files#diff-dbb3a62ac313f00ac7caf30816c208bdR91
|
This PR depends on #21008 to run successfully in a vstart environment. |
added 2 commits
March 23, 2018 11:11
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
Skip the test case 'test_create_rbd_in_data_pool' only if the cluster does not support bluestore, otherwise run the test. The Ceph mgr provides the information if the cluster supports bluestore or not, so the test will be skipped depending on the current cluster. Signed-off-by: Tatjana Dehler <tdehler@suse.com>
s0nea
force-pushed
the
wip-dashboard-skip-datapool-testcase
branch
from
9e0bfaf
to
0751024
Compare
|
I'm running into: Seems to be a timing issue where |
|
And now I'm running into |
|
Strange that this 400 error occurs now and not in the pull request before when the 'test_create' test case was added. This pull request doesn't contain any changes for this test case nor the RBD create functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the 'test_create_rbd_in_data_pool' test case so that it won't always be skipped. It will only be skipped if the cluster does not support bluestore.
Signed-off-by: Tatjana Dehler tdehler@suse.com