mgr/dashboard: Add submit button component #21011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
approved these changes
Mar 23, 2018
votdev
reviewed
Mar 23, 2018
| * | ||
| * To indicate that the request failed, returning the button to the enable | ||
| * state, you need to insert an error in the form with the 'cdSubmitButton' key. | ||
| * p.e.: this.rbdForm.setErrors({'cdSubmitButton': 'ERR'}); |
There was a problem hiding this comment.
Maybe use this.rbdForm.setErrors({'cdSubmitButton': true}); as an example.
|
@tspmelo rebase on top of master |
This component is to be used inside a form. It will render a submit button with the given label. The button will disabled itself and show a loading icon when the user clicks it, usually initiating a request to the server, and it will stay in that state until the request is finished. To indicate that the request failed, returning the button to the enable state, you need to insert an error in the form with the 'cdSubmitButton' key. It will also check if the form is valid, when clicking the button, and will focus on the first invalid input. Signed-off-by: Tiago Melo <tmelo@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component is to be used inside a form.
It will render a submit button with the given label.
The button will disabled itself and show a loading icon when the user clicks it,
usually initiating a request to the server, and it will stay in that state
until the request is finished.
To indicate that the request failed, returning the button to the enable state,
you need to insert an error in the form with the 'cdSubmitButton' key.
It will also check if the form is valid, when clicking the button, and will
focus on the first invalid input.
Signed-off-by: Tiago Melo <tmelo@suse.com>