fuse: handle errors appropriately when getting group list #21025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the GET_GROUPS macro just ignores errors that can occur when attempting to get the list of groups. Change it to a real function that returns an error when getting groups fails, and check for errors in the callers. Tracker: http://tracker.ceph.com/issues/23446 Signed-off-by: Jeff Layton <jlayton@redhat.com>
jtlayton
requested review from
batrick,
gregsfortytwo,
jcsp,
fullerdj and
ukernel
|
Teuthology tests are running now: |
|
Retest this please |
|
getgroups() may return -ENOSYS. I think ceph-fuse shouldn't reply error in this case. besides, do we really need to reply error immediately. how about just set count to 0 |
|
Thanks @ukernel. That does make a lot more sense -- let's do that. We can have it log an error when fetching groups fails with a hard error too, which would make it easier to debug problems when they occur. I'll close this request for now, and reopen it once I re-roll the patch to do that. |
|
I like the error checking in this patch so let's keep those parts. I agree that using an empty group list makes sense for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the GET_GROUPS macro just ignores errors that can occur when
attempting to get the list of groups. Change it to a real function that
returns an error when getting groups fails, and check for errors in the
callers.
Tracker: http://tracker.ceph.com/issues/23446
Signed-off-by: Jeff Layton jlayton@redhat.com