Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Fix typo in comment #21032

Merged
merged 1 commit into from Mar 26, 2018
Merged

rgw: Fix typo in comment #21032

merged 1 commit into from Mar 26, 2018

Conversation

simransinghal
Copy link
Contributor

Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't".

Signed-off-by: Simran Singhal singhalsimran0@gmail.com

Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't".

Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
@wjwithagen
Copy link
Contributor

@simransinghal
Typos in comments are only fixed if there is also a code fix at the same location.
And then I forgo the very long discussion we had about 1 year ago about all kind of colloquialisms, UK vs US english, and other languages style prefferences.
So might I polittely suggest to close this.

@joscollin
Copy link
Member

@wjwithagen May be this one. #16705. :-)

But dont is incorrect I think.

@simransinghal
Copy link
Contributor Author

simransinghal commented Mar 26, 2018

@wjwithagen @joscollin
Yes, "dont" is not a dictionary word.
And even Linux kernel style does not prefer such kind of mistakes. So, it's good if we change this.

@joscollin joscollin changed the title src: Fix typo src: Fix typo in comment Mar 26, 2018
@joscollin joscollin changed the title src: Fix typo in comment rgw: Fix typo in comment Mar 26, 2018
@joscollin joscollin merged commit bf82cb2 into ceph:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants