doc: dev description of async recovery #21051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
tchaikov
reviewed
Mar 27, 2018
| PGs in Ceph maintain a log of writes to allow speedy recovery of data. | ||
| Instead of scanning all of the objects to see what is missing on each | ||
| osd, we can examine the pg log to see which objects we need to | ||
| recover. See `Log Based PG`_ for more detail on this process. |
There was a problem hiding this comment.
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/dev/osd_internals/async_recovery.rst:5:Unknown target name: "log based pg".
neha-ojha
force-pushed
the
wip-doc-async-recovery
branch
from
184c424
to
9a9a9e4
Compare
jdurgin
reviewed
Mar 27, 2018
| recover. See `Log Based PG`_ for more detail on this process. | ||
|
|
||
| .. _`Log Based PG`: | ||
| https://github.com/ceph/ceph/blob/master/doc/dev/osd_internals/log_based_pg.rst |
There was a problem hiding this comment.
relative path, in this case just log_based_pg.rst, should work
|
could you preserve my signed-off-by on the commit since it's not changed much since the original draft |
neha-ojha
force-pushed
the
wip-doc-async-recovery
branch
from
9a9a9e4
to
b2b28fc
Compare
Signed-off-by: Josh Durgin <jdurgin@redhat.com> Signed-off-by: Neha Ojha <nojha@redhat.com>
neha-ojha
force-pushed
the
wip-doc-async-recovery
branch
from
b2b28fc
to
5cc9252
Compare
jdurgin
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Durgin jdurgin@redhat.com
Signed-off-by: Neha Ojha nojha@redhat.com