Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Support aditional info on 'cd-view-cache' #21060

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
4 participants
@ricardoasmarques
Copy link
Member

commented Mar 27, 2018

This PR adds support for addition information on cd-cache-view component.

By using the statusFor attribute, the developer will be able to add additional information text that will be displayed by the component.

Usage:
<cd-view-cache [status]="2" statusFor="pool <strong>rbd1</strong>"></cd-view-cache>
screenshot from 2018-03-27 11-09-54

Signed-off-by: Ricardo Marques rimarques@suse.com

mgr/dashboard: Support aditional info on 'cd-view-cache'
Signed-off-by: Ricardo Marques <rimarques@suse.com>

@ricardoasmarques ricardoasmarques requested a review from tspmelo Mar 27, 2018

@LenzGr LenzGr requested a review from Devp00l Mar 27, 2018

@LenzGr

LenzGr approved these changes Mar 27, 2018

Copy link
Contributor

left a comment

LGTM

@rjfd rjfd merged commit 00ba38f into ceph:master Apr 4, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.