common: Add metadata with only Ceph version number and release #21095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This metadata is very easy to have, shorter strings and no parsing on the consumer side. |
This prevents consumers from this data to have to fully parse and split the 'ceph_version' string which is prone to errors. ceph_version_short only contains the version number (maj, min, patch) and ceph_release the codename, eg, luminous. Signed-off-by: Wido den Hollander <wido@42on.com>
wido
force-pushed
the
ceph-metadata-version
branch
from
e0cc648
to
2a745f5
Compare
liewegas
approved these changes
Apr 2, 2018
jcsp
approved these changes
Apr 2, 2018
|
@wido don't forget that when consuming these fields, you'll need to have fallbacks for the next 2 releases, to handle older daemons. |
|
@jcsp Yes, I will check for that. But I think it should be nice to have these fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents consumers from this data to have to fully parse
and split the 'ceph_version' string which is prone to errors.
ceph_version_short only contains the version number (maj, min, patch)
and ceph_release the codename, eg, luminous.
Signed-off-by: Wido den Hollander wido@42on.com