mgr/dashboard: Update selected items on table refresh

[ricardoasmarques]

After updating table data (either by pressing refresh button or by automatic refresh), selected rows should be updated to guarantee that user will see the updated details of the selected row.

Signed-off-by: Ricardo Marques rimarques@suse.com

[tspmelo]

I think you need to add trackBy to some tables or save the state some other way.
ATM if you select a row in the OSD page, the details keep being recreated.

[Devp00l]

Which tables are affected by this problem?

The detail view should update itself if it's data has changed, through the usage of Observables through Angular.

[ricardoasmarques]

@tspmelo I've added a new table input updateSelectionOnRefresh, so you can control if you want selection details update on table refresh, or not (false by default).

[ricardoasmarques]

@Devp00l this will affect all pages where you have a Details tab, that displays information from the selected row (without doing a new server request).

In particual, it affects my WIP RBD details page:

And also my WIP RBD snapshots page (because snapshots list is included in the row data, so I don't have to do a separate server request).

Do you still think that Observables are applicable here?

[votdev]

I suggest to set it to true by default and force the developer to explicitly set it to false if he does not like this behaviour for his table.

[ricardoasmarques]

@votdev I've changed the default value to true

[Devp00l]

@ricardoasmarques I was assuming that angular would update the details accordingly as it uses observables in the background. Also the ngx-table should update the selection accordingly. Maybe it's a bug in the table?

[Devp00l]

lgtm