Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common, osd: duplicated "start" event in OpTracker, improve OpTracker::dump_ops #21119

Merged
merged 3 commits into from Apr 7, 2018

Conversation

liuchang0812
Copy link
Contributor

  1. there are two "started" event in EC osd_op : PrimaryLogPG::do_op, ECBackend::handle_sub_write.

  2. no need to sort events in OpHistory::dump_ops_by_duration. We could use OpHistory::duration directly

  3. refine OpHistory::dump_ops & OpHistory::dump_ops_by_duration

[

                  {
                        "time": "2018-03-29 17:30:30.343031",
                        "event": "initiated"
                    },  
                    {
                        "time": "2018-03-29 17:30:30.343031",
                        "event": "header_read"
                    },  
                    {
                        "time": "2018-03-29 17:30:30.343035",
                        "event": "throttled"
                    },  
                    {
                        "time": "2018-03-29 17:30:30.345821",
                        "event": "all_read"
                    },  
                    {
                        "time": "2018-03-29 17:30:30.345873",
                        "event": "dispatched"
                    },  
                    {
                        "time": "2018-03-29 17:30:30.345913",
                        "event": "queued_for_pg"
                    },  
                    {
                        "time": "2018-03-29 17:30:31.783523",
                        "event": "reached_pg"
                    },  
                    {
                        "time": "2018-03-29 17:30:31.783610",
                        "event": "started"
                    },  
                    {
                        "time": "2018-03-29 17:30:31.790104",
                        "event": "sub_op_started"          # <-- here is "started" without this patch
                    },  
                    {
                        "time": "2018-03-29 17:30:32.367766",
                        "event": "sub_op_committed"
                    },  
                    {
                        "time": "2018-03-29 17:30:32.367797",
                        "event": "commit_sent"
                    },  
                    {
                        "time": "2018-03-29 17:30:32.367830",
                        "event": "done"
                    }
]

…ration

Signed-off-by: Chang Liu <liuchang0812@gmail.com>
Signed-off-by: Chang Liu <liuchang0812@gmail.com>
Signed-off-by: Chang Liu <liuchang0812@gmail.com>
Signed-off-by: ashitakasam 694240887@qq.com
@liuchang0812
Copy link
Contributor Author

hi, @liewegas mind taking a look?

and, should we add "waiting for subops from" & "receive sub op from" event to ECBackend? thanks

@tchaikov tchaikov self-requested a review April 2, 2018 13:26
@tchaikov tchaikov merged commit 52012a0 into ceph:master Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants