New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mon,mgr: remove single wildcard '*' from ceph comand line description #21139
Conversation
because wildcard doesn't work.The '*' is consumed and translated to current dir/file name before passing to ceph. remove it from CLI description. Signed-off-by: Gu Zhongyan <guzhongyan@360.cn>
take 'ceph osd in *' as an example: $bin/ceph osd in * --verbose we can see childdargs are parsed as following: |
I kept the *.cc code logic unchanged, such as:
not sure if they should also be cleaned up. |
The "*" works fine if the user quotes it, but I agree that those versions are pretty bad for usability and redundant when we also have "all", so 👍 |
probably we can mark |
Adding mimic milestone: this one is only changing doc strings but let's let it go through testing anyway. |
retest this please (jenkins) |
Tested here: http://pulpito.ceph.com/jspray-2018-04-24_01:06:58-rados:mgr-wip-jcsp-testing-20180423-distro-basic-smithi/ All failures are the MDS_ALL_DOWN log message thing addressed elsewhere |
because wildcard doesn't work.The '*' is consumed and
translated to current dir/file name before passing to ceph.
remove it from CLI description.
Signed-off-by: Gu Zhongyan guzhongyan@360.cn