tools: FreeBSD basic getopt does not use --options #21148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
reviewed
Mar 31, 2018
src/tools/setup-virtualenv.sh
Outdated
| @@ -17,6 +17,11 @@ | |||
|
|
|||
| SCRIPTNAME="$(basename $0)" | |||
| PYTHON_BINARY="python2.7" | |||
| if [ `uname` == FreeBSD ]; then | |||
| GETOPT=/usr/local/bin/getopt | |||
There was a problem hiding this comment.
put /usr/local/bin/getopt in double-quotes?
smithfarm
reviewed
Mar 31, 2018
src/tools/setup-virtualenv.sh
Outdated
| if [ `uname` == FreeBSD ]; then | ||
| GETOPT=/usr/local/bin/getopt | ||
| else | ||
| GETOPT=getopt |
There was a problem hiding this comment.
put getopt in double-quotes? I know it's not striclty necessary - just to unify the coding style.
There was a problem hiding this comment.
@smithfarm
Sure, no problem.
wjwithagen
force-pushed
the
wjw-setup-virtualenv
branch
from
c5ef2aa
to
8f65db3
Compare
|
retest this please |
|
retest this please. |
|
@smithfarm @tchaikov |
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
wjwithagen
force-pushed
the
wjw-setup-virtualenv
branch
from
8f65db3
to
877d856
Compare
|
retest this please. |
|
Failed run-rbd-unit-tests.sh Failed unittest_journal (crashes on assert(!m_metadata->is_initialized()) |
|
retest this please |
|
@smithfarm this PR compiles. so i guess it's good to merge, am i right? |
smithfarm
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Willem Jan Withagen wjw@digiware.nl