[DNM] jewel: client: dual client segfault with racing ceph_shutdown #21153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can do it under the same mutex, which should be more efficient. Signed-off-by: Jeff Layton <jlayton@redhat.com> (cherry picked from commit 01863bb)
If the cct is unregistered while other threads are flogging mutexes, then we can hit all sorts of bugs. Ensure that we handle that situation sanely, by checking that g_lockdep is still set after we take the lockdep_mutex. Also, remove an assertion from lockdep_unregister, and just turn it into an immediate return. It's possible to have a call to lockdep_unregister_ceph_context, and then a call to lockdep_register_ceph_context while a mutex is being held by another task. In that case, it's possible the lock does not exist in the map when we go to unregister it. That's not a bug though, just a natural consequence of that series of actions. Tracker: http://tracker.ceph.com/issues/20988 Signed-off-by: Jeff Layton <jlayton@redhat.com> (cherry picked from commit 75f41a9)
The build says:
src/client/Client.cc: In member function ‘void Client::trim_caps(MetaSession*, int)’:
src/client/Client.cc:4121:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (s->caps.size() > max)
~~~~~~~~~~~~~~~^~~~~
Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit e057b67)
Spawn threads that bring up a bunch of ceph_mounts with individual CephContext objects, and then tear them down in parallel. Tracker: http://tracker.ceph.com/issues/20988 Signed-off-by: Jeff Layton <jlayton@redhat.com> (cherry picked from commit 8252f31)
...and make g_lockdep a bool. Signed-off-by: Jeff Layton <jlayton@redhat.com> (cherry picked from commit 0cd0bd7) Conflicts: src/test/common/test_mutex.cc (file does not exist in jewel)
|
Does this need rados suite as well as fs? |
|
@smithfarm probably just need the |
jcsp
approved these changes
Apr 2, 2018
smithfarm
changed the title
|
This PR adds ShutdownRace test case to ceph_test_libcephfs, but it appears to segfault every time: http://tracker.ceph.com/issues/23556 Removing this PR from the integration branch and retesting. |
|
This PR passed a rados suite at http://tracker.ceph.com/issues/21742#note-21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/21526