Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: s/pip --use-wheel/pip/ #21159

Merged
merged 1 commit into from Apr 2, 2018

Conversation

Projects
None yet
2 participants
@tchaikov
Copy link
Contributor

commented Apr 1, 2018

--use-wheel was deprecated in favor of --only-binary in pip v7.0.0. and
--use-wheel was removed in a recent release of pip.

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov added the build/ops label Apr 1, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2018

retest this please.

src: s/--use-wheel//
--use-wheel was deprecated in favor of --only-binary in pip v7.0.0. and
--use-wheel was removed in a recent release of pip. but some packages
are source packages, so we cannot simply replace use-wheel with
only-binary. so a simpler approach is to drop --use-wheel option, as pip
respects --find-links, and will find the required package from the
wheelhouse.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov force-pushed the tchaikov:wip-no-more-use-wheel branch from 9df73e2 to a80cce4 Apr 1, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2018

probably what we want is pypa/pip#3785 ...

@tchaikov tchaikov requested review from rjfd and alfredodeza Apr 1, 2018

@tchaikov tchaikov changed the title src: s/pip --use-wheel/pip --only-binary/ src: s/pip --use-wheel/pip/ Apr 1, 2018

@tchaikov tchaikov added the backport label Apr 1, 2018

@tchaikov tchaikov requested a review from smithfarm Apr 1, 2018

@tchaikov tchaikov requested a review from badone Apr 1, 2018

@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit 3cd8489 into ceph:master Apr 2, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-no-more-use-wheel branch Apr 2, 2018

epuertat added a commit to rhcs-dashboard/ceph that referenced this pull request Jul 27, 2018

mgr/dashboard: remove --use-wheel from dashboard pip
Commit a80cce4 (PR ceph#21159) fixed this in master dashboard_v2 makefile,
and was partially backported to Luminous (3cd8489).

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.