Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-replay: remove boost dependency #21202

Merged
merged 1 commit into from Apr 3, 2018
Merged

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Apr 3, 2018

quite a few facilies are now available in standard library now after we
switched to C++17.

Signed-off-by: Kefu Chai kchai@redhat.com

quite a few facilies are now available in standard library now after we
switched to C++17.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Apr 3, 2018

i found this change in my local repo. i prepared it when debugging a boost compiling issue when we were moving to C++17. but i think it's still desirable to have less dependency. but i failed to find a test for "rbd_replay".

Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dillaman dillaman merged commit 98bae81 into ceph:master Apr 3, 2018
@tchaikov tchaikov deleted the wip-rbd-replay branch April 3, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants