[DNM] jewel: rgw: copying part without http header x-amz-copy-source-range will be mistaken for copying object

[smithfarm]

http://tracker.ceph.com/issues/22904

[smithfarm]

@mattbenjamin See the conflict resolution - it made sense in my mind to add the url_decode(...)

[smithfarm]

rgw/rgw_op.cc: In member function ‘virtual void RGWPutObj::execute()’:
rgw/rgw_op.cc:2673:22: error: request for member ‘empty’ in ‘((RGWPutObj*)this)->RGWPutObj::copy_source’, which is of non-class type ‘const char*’
   if ((! copy_source.empty()) && !copy_source_range) {
                      ^
rgw/rgw_op.cc:2679:85: error: no matching function for call to ‘RGWRados::get_obj_state(RGWObjectCtx*, RGWBucketInfo&, rgw_obj&, RGWObjState**, bool, bool)’
                                   copy_source_bucket_info, obj, &astate, true, false);
                                                                                     ^
In file included from rgw/rgw_op.cc:16:0:
rgw/rgw_rados.h:2732:7: note: candidate: int RGWRados::get_obj_state(RGWObjectCtx*, rgw_obj&, RGWObjState**, bool)
   int get_obj_state(RGWObjectCtx *rctx, rgw_obj& obj, RGWObjState **state, bool follow_olh);
       ^
rgw/rgw_rados.h:2732:7: note:   candidate expects 4 arguments, 6 provided
rgw/rgw_rados.h:2733:7: note: candidate: int RGWRados::get_obj_state(RGWObjectCtx*, rgw_obj&, RGWObjState**)
   int get_obj_state(RGWObjectCtx *rctx, rgw_obj& obj, RGWObjState **state) {
       ^
rgw/rgw_rados.h:2733:7: note:   candidate expects 3 arguments, 6 provide

[mattbenjamin]

@smithfarm I think your merge of the url_decode patch lost a bit--the member copy_source was a char pointer, and is now a std::string iirc.

Matt

[joke-lee]

hi @malc0lm @mattbenjamin @smithfarm ,i update the code in this pr #21294

[smithfarm]

closing in favor of #21294