Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/hobject: preserve the order of hobject #21217

Merged
merged 1 commit into from Apr 7, 2018

Conversation

Projects
None yet
3 participants
@tchaikov
Copy link
Contributor

commented Apr 3, 2018

we cannot change the sort order of hobject. and to avoid duplicated
comparisions, we can check for empty keys, and do not compare the names
again if both hobjects being compared have empty keys.

Signed-off-by: Kefu Chai kchai@redhat.com

common/hobject: fix the sort order of hobject
we *cannot* change the sort order of hobject. and to avoid duplicated
comparisions, we can check for empty keys, and do not compare the names
again if both hobjects being compared have empty keys.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@xiexingguo
Copy link
Member

left a comment

Thanks for the quick fix:-)

@tchaikov tchaikov merged commit 4cfc09d into ceph:master Apr 7, 2018

4 of 5 checks passed

make check (arm64) make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-cmp-hobject branch Apr 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.