Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: TaskManager bug fixes #21240

Merged
merged 2 commits into from Apr 6, 2018

Conversation

Projects
None yet
5 participants
@rjfd
Copy link
Contributor

commented Apr 4, 2018

This PR fixes two bugs in the asynchronous task infrastructure. The first is a bug in the serialization of task that raised an exception. The second is a bug in the management of the finished tasks list.

Signed-off-by: Ricardo Dias rdias@suse.com

rjfd added some commits Mar 29, 2018

mgr/dashboard: fix exception serialization for tasks
Signed-off-by: Ricardo Dias <rdias@suse.com>
mgr/dashboard: TaskManager: implement finished tasks as a list
Signed-off-by: Ricardo Dias <rdias@suse.com>
@ricardoasmarques
Copy link
Member

left a comment

lgtm

@batrick

This comment has been minimized.

Copy link
Member

commented Apr 4, 2018

retest this please

@rjfd

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2018

jenkins retest this please

@LenzGr LenzGr merged commit 6def989 into ceph:master Apr 6, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.