mgr/dashboard: Implement a RGW proxy #21258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
requested review from
LenzGr,
sebastian-philipp,
s0nea,
p-se,
ricardoasmarques and
rjfd
|
retest this please |
|
I re-tested this on a local branch against the frontend PR proposed in #20869 and it worked as advertised. |
rjfd
suggested changes
Apr 6, 2018
| except NoCredentialsException as e: | ||
| cherrypy.response.headers['Content-Type'] = 'application/json' | ||
| cherrypy.response.status = 401 | ||
| return json.dumps({'message': str(e)}) |
There was a problem hiding this comment.
This line triggers an exception in cherrypy when running in python 3 because of the return type. Please change this line to:
return json.dumps({'message': str(e)}).encode('utf-8')
|
The proxy is sending the wrong content-type: |
sebastian-philipp
previously requested changes
Apr 6, 2018
rjfd
suggested changes
Apr 6, 2018
| return daemon | ||
|
|
||
|
|
||
| @ApiController('rgw/proxy') |
votdev
changed the title
votdev
changed the title
|
@sebastian-philipp After adapting the RGW proxy controller to #21239 the endpoint 'rgw/proxy' does not exist anymore and you'll get an error message with correct content-type: |
|
jenkins retest this please |
votdev
force-pushed
the
rgw_proxy
branch
4 times, most recently
from
5b1a60b
to
6b0ce1c
Compare
votdev
force-pushed
the
rgw_proxy
branch
3 times, most recently
from
81367f3
to
88deec8
Compare
|
QA tests failed: http://pulpito.ceph.com/rdias-2018-04-10_13:03:34-rados:mgr-wip-rdias-testing-distro-basic-mira/ Teuthology log: http://qa-proxy.ceph.com/teuthology/rdias-2018-04-10_13:03:34-rados:mgr-wip-rdias-testing-distro-basic-mira/2380150/teuthology.log After some investigation with @p-na we found out that the current RGW backend code is assuming that there is alwasy an RGW daemon in the service map with This is the output of the service map of the teuthology run: |
|
Just for documentation, the service map using vstart looks like |
votdev
force-pushed
the
rgw_proxy
branch
3 times, most recently
from
3084293
to
68cb890
Compare
|
@rjfd The |
votdev
force-pushed
the
rgw_proxy
branch
2 times, most recently
from
ed9f228
to
aac311d
Compare
|
QA tests run successful: http://pulpito.ceph.com/rdias-2018-04-11_08:29:22-rados:mgr-wip-rdias-testing-distro-basic-mira/ |
rjfd
approved these changes
Apr 11, 2018
This commit will include the `python-requests-aws` [1] library. This library extends the `requests` library by an authentication mechanism to S3 gateways. [1] https://github.com/tax/python-requests-aws Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
This implementation is basically a Rados Gateway reverse proxy. It
additionally takes care of the authentication to the Rados Gateway, but to use
it you will have to be authenticated against the dashboards RESTful API.
The corresponding credentials can be configured using the following commands:
dashboard set-rgw-api-secret-key <secret-key>
dashboard set-rgw-api-access-key <access-key>
Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
Signed-off-by: Volker Theile <vtheile@suse.com>
LenzGr
dismissed
sebastian-philipp’s stale review
Addressed by #21258 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a RGW proxy which can be used by the frontend to talk to the RGW Admin Ops API.
This PR takes over #20799.