Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: only test enabled python bindings #21293

Merged
merged 3 commits into from Apr 13, 2018

Commits on Apr 11, 2018

  1. test/dashboard: only test enabled python bindings

    we should test the python version of MGR_PYTHON_VERSION_MAJOR, if we are
    testing both py2.7 and py3, we are preparing for distributing dashboard
    as a separated package independent of ceph-mgr.
    
    restructure the dashboard tests as 2 matrices, so we have 2*2 tests for
    coverage and lint respectively.
    
    Signed-off-by: Kefu Chai <kchai@redhat.com>
    tchaikov committed Apr 11, 2018
    Copy the full SHA
    213652a View commit details
    Browse the repository at this point in the history
  2. cmake: no need to setup venv for dashboard

    unlike ceph-disk and ceph-detect-init, dashboard is not a standalone
    python application, it is a python application hosted by ceph-mgr,
    so no need to create a venv in which it is deployed. the python env
    created by tox would suffice.
    
    Signed-off-by: Kefu Chai <kchai@redhat.com>
    tchaikov committed Apr 11, 2018
    Copy the full SHA
    b41e049 View commit details
    Browse the repository at this point in the history
  3. pybind/mgr/dashboard: silence lint warnings

    this silences following errors:
    
    9: ./awsauth.py:42:1: E722 do not use bare except'
    9: ./awsauth.py:116:13: E722 do not use bare except'
    
    Signed-off-by: Kefu Chai <kchai@redhat.com>
    tchaikov committed Apr 11, 2018
    Copy the full SHA
    c5a004d View commit details
    Browse the repository at this point in the history