rbd-mirror: integrate image map policy as incremental step to active-active #21300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
reviewed
Apr 9, 2018
src/tools/rbd_mirror/LeaderWatcher.h
Outdated
| * . | ^ . .....^..................... | ||
| * . v (error) | . | | ||
| * .INIT_INSTANCES *> SHUT_DOWN_STATUS_WATCHER . RELEASE_LEADER_LOCK | ||
| * .INIT_INSTANCES *> SHUT_DOWN_STATUS_WATCHER . .NOTIFY_LOCK_RELEASED . |
There was a problem hiding this comment.
@dillaman Need to remove SHUT_DOWN_STATUS_WATCHER here too.
| if (r < 0) { | ||
| Mutex::Locker locker(m_lock); | ||
| derr << "error initializing instances: " << cpp_strerror(r) << dendl; | ||
| m_ret_val = r; |
There was a problem hiding this comment.
It looks like there is no need to set m_ret_val here any more.
dillaman
force-pushed
the
wip-rbd-mirror-active-active
branch
from
897179d
to
cc0acd4
Compare
trociny
reviewed
Apr 10, 2018
src/tools/rbd_mirror/Instances.cc
Outdated
| } | ||
| } | ||
|
|
||
| dout(5) << "instance_ids=" << added_instance_ids << dendl; |
There was a problem hiding this comment.
Probably skip the part below if added_instance_ids happens to be empty?
src/tools/rbd_mirror/Instances.cc
Outdated
| m_listener.handle_added(added_instance_ids); | ||
| m_lock.Lock(); | ||
|
|
||
| for (auto& instance_id : instance_ids) { |
There was a problem hiding this comment.
Shouldn't we iterate over added_instance_ids here?
dillaman
force-pushed
the
wip-rbd-mirror-active-active
branch
2 times, most recently
from
7b5986e
to
f1d2fab
Compare
added 17 commits
April 10, 2018 16:31
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
…class Signed-off-by: Jason Dillaman <dillaman@redhat.com>
In the case of active/active, both the leader and the followers will be sending status updates for their images. Therefore, all rbd-mirror daemons should be registered. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This throttles the on-disk updates and also will eventually help to throttle the shuffling of images between alive peer instances. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Avoid a possible race condition with instances being detected before the pool replayer leader handling is fully initialized. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The context wraps the necessary data and provides a pass-through chain to the instance notification helpers. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The context callbacks between the image map and its policy required too many hooks between the two classes. Additionally, the original implementation didn't support re-sending of acquire messages after initializing (to close a potential race condition). Signed-off-by: Jason Dillaman <dillaman@redhat.com>
At initial promotion to the leader position, it can be nearly always assumed that at least one instance has died and needs to have its images shuffled to another instance (i.e. the old leader). Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-rbd-mirror-active-active
branch
from
f1d2fab
to
10522f4
Compare
|
@ceph-jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.