crush/CrushWrapper: fix potential invalid use of iterator #21325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In choose_leaf mode we normally should have a stack of 2 and hence below here we still need to re-check the iterator against the stack loop. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
…ain OSD Assume we have a pool of crush-failure-domain OSD, then the stack will look like: [ "0":"8" // stack[0] "0":"1" // stack[1] ] The above stack is error-prone because when passed to _choose_type_stack(), iterator **i** shall already point to orig.end() when stack[0] is done and might still get incremented while we continues to handle stack[1], and hence produce the following abnormal (**overflowed**) mapping results: ``` -36> 2018-04-06 23:06:35.041274 7f84692bd700 10 total_deviation 24.6667 overfull 4,5,6,7,8 underfull [2,0,3,9] -35> 2018-04-06 23:06:35.041278 7f84692bd700 10 osd.7 move 3 -34> 2018-04-06 23:06:35.041280 7f84692bd700 10 trying 2.0 -33> 2018-04-06 23:06:35.041310 7f84692bd700 10 2.0 [3,5,6,4,9,0,7,10] -> [1953720676,1683976050,1919120229,1769238633,838889071,3224629,101,2] -32> 2018-04-06 23:06:35.041317 7f84692bd700 10 2.0 pg_upmap_items [3,1953720676,5,1683976050,6,1919120229,4,1769238633,9,838889071,0,3224629,7,101,10,2] ``` See also: http://pulpito.ceph.com/yuriw-2018-04-06_21:35:03-rados-wip-yuri2-testing-2018-04-06-1946-luminous-distro-basic-smithi/2365151/ Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@liewegas Can you look? |
liewegas
approved these changes
Apr 11, 2018
|
This passed two perfect (:rofl: ) rounds of rados QA run: http://pulpito.ceph.com/xxg-2018-04-11_07:24:02-rados-wip-fix-up-seg-error-distro-basic-smithi/ http://pulpito.ceph.com/xxg-2018-04-10_09:28:18-rados-wip-fix-up-seg-error-distro-basic-smithi/ |
|
luminous backport: #21359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.