pybind/ceph_argparse: Fix UnboundLocalError if command doesn't validate #21342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error case in validate_command() where the command is found but the
command itself is somehow invalid raises an UnboundLocalError, because it
tries to refer to a variable named 'e', but it should be 'ex'. For example:
# ceph balancer mode
Traceback (most recent call last):
File "/usr/bin/ceph", line 1178, in <module>
retval = main()
File "/usr/bin/ceph", line 1109, in main
verbose)
File "/usr/bin/ceph", line 535, in new_style_command
valid_dict = validate_command(sigdict, cmdargs, verbose)
File "/usr/lib/python3.6/site-packages/ceph_argparse.py", line 1090, in validate_command
print("Invalid command:", e, file=sys.stderr)
UnboundLocalError: local variable 'e' referenced before assignment
Replacing 'e' with 'ex' gives the desired output:
# ceph balancer mode
Invalid command: missing required parameter mode(none|crush-compat|upmap)
balancer mode none|crush-compat|upmap : Set balancer mode
Error EINVAL: invalid command
Signed-off-by: Tim Serong <tserong@suse.com>
tchaikov
approved these changes
Apr 11, 2018
|
failed tests are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error case in validate_command() where the command is found but the
command itself is somehow invalid raises an UnboundLocalError, because it
tries to refer to a variable named 'e', but it should be 'ex'. For example:
Replacing 'e' with 'ex' gives the desired output:
Signed-off-by: Tim Serong tserong@suse.com