rpm,debian: Ensure all ceph-disk runtime dependencies are declared for ceph-base #21356
Conversation
In Debian "gdisk" is already listed under ceph-base, so this commit is RPM-only. sgdisk is only used by ceph-disk (part of "ceph-base"), not by ceph-volume (part of "ceph-osd") Fixes: http://tracker.ceph.com/issues/23657 Signed-off-by: Nathan Cutler <ncutler@suse.com>
|
Just a quick note: ceph-volume doesn't use |
Since ceph-disk has been moved from "ceph-osd" to "ceph-base", all of ceph-disk's dependencies should also be moved, provided they are not needed by anything else. Fixes: http://tracker.ceph.com/issues/23657 Signed-off-by: Nathan Cutler <ncutler@suse.com>
|
Changelog:
|
|
@alfredodeza OK, updated. What is the magic incantation to trigger ceph-volume tests on this PR? |
|
@smithfarm you would need to push to ceph-ci so that we can get packages build for functional tests. For reporting into this PR the branch name would need to be the same name, so that packages can appear at https://shaman.ceph.com/builds/ceph/wip-23657/ |
|
Nevermind, Kefu already pushed this PR to ceph-ci under a different branch name, so that URL will not work. |
|
@tchaikov What's the name of your ceph-ci branch that contains this PR? I couldn't find it. @alfredodeza would like to trigger https://jenkins.ceph.com/view/all/job/ceph-volume-test/ on it. |
|
@smithfarm it's wip-kefu-testing-2018-04-12-1450 . |
|
now that we've changed to disallow branches on ceph.git none of the ceph-volume jobs will work, they were depending on having branches in ceph.git (not elsewhere). This will take a while to get everything wired up correctly. I will run these tests manually from Kefu's branch/packages |
|
failed tests are |
tchaikov
changed the title
|
These changes worked for me locally. |
|
Thanks to @tchaikov and @alfredodeza for testing. |
The sgdisk and parted dependencies are not used by ceph-volume, or by anything other than ceph-disk, so move them to ceph-base.
Fixes: http://tracker.ceph.com/issues/23657