mgr/dashboard: Rename and refactor ApiInterceptorService class #21386
Conversation
votdev
force-pushed
the
api_interceptor
branch
2 times, most recently
from
4551a2c
to
e1d4cde
Compare
votdev
changed the title
| break; | ||
| } | ||
| this.notificationService.show( |
There was a problem hiding this comment.
We cannot display a generic error when we receive a 409 error code.
409 is used on RBD management to display validation errors returned by ceph.
There was a problem hiding this comment.
Same problem with RGW; it returns 404 for some errors which is totally wrong in case of the UI because it will redirect the UI to the 404 page. I fixed that by catching all exceptions coming from the RGW proxy and return them as 500.
There was a problem hiding this comment.
Could we extend this to use something like preventDefault to prevent the routing in specific cases?
There was a problem hiding this comment.
@Devp00l Could you please explain it more detailed because this PR does not change general logic of the existing code. maybe your suggestion should be done with a separate PR.
There was a problem hiding this comment.
@votdev we cannot implement an equivalent solution for RBDs because returning 409 in RBD is intentional.
There was a problem hiding this comment.
@ricardoasmarques HTTP 409 error codes do not show notifications anymore.
| break; | ||
| } | ||
| this.notificationService.show( |
There was a problem hiding this comment.
Could we extend this to use something like preventDefault to prevent the routing in specific cases?
…ifications for more errors than 401 and 500. Signed-off-by: Volker Theile <vtheile@suse.com>
Signed-off-by: Volker Theile <vtheile@suse.com>
Signed-off-by: Volker Theile <vtheile@suse.com>
|
@Devp00l I've added the ability to cancel a notification. |
Display notifications for more errors than 401 and 500.
Signed-off-by: Volker Theile vtheile@suse.com