Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Angular modules cleanup #21402

Merged
merged 1 commit into from Apr 16, 2018
Merged

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Apr 13, 2018

Removed the import of modules that were already being imported through the
Shared module.

Removed duplicated providers, those services were already provided in the api
module.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Removed the import of modules that were already being imported through the
Shared module.

Removed duplicated providers, those services were already provided in the api
module.

Signed-off-by: Tiago Melo <tmelo@suse.com>
@LenzGr LenzGr added the cleanup label Apr 13, 2018
Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LenzGr LenzGr merged commit f401af9 into ceph:master Apr 16, 2018
@tspmelo tspmelo deleted the wip-module-cleanup branch May 2, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants