test/dashboard: specify workdir using tox.ini #21416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--workdir was introduced in tox v2.4.0, but the tox shipped by ubuntu/xenial is 2.3.1. also because i removed the step to prepare the tox using "pip install -r requirements.txt", what we have is the tox v2.3.1 . so, instead of passing workdir in the command line, we specify this setting in tox.ini. also drop the tox in requirements.txt, it's just misleading. and we are not using the tox installed in the venv. Fixes: http://tracker.ceph.com/issues/23709 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
Looks sane to me, especially as |
rjfd
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--workdir was introduced in tox v2.4.0, but the tox shipped by
ubuntu/xenial is 2.3.1. also because i removed the step to prepare the
tox using "pip install -r requirements.txt", what we have is the tox
v2.3.1 . so, instead of passing workdir in the command line, we specify
this setting in tox.ini.
Fixes: http://tracker.ceph.com/issues/23709
Signed-off-by: Kefu Chai kchai@redhat.com