osd: remove cost from mclock op queues; cost not handled well in dmcl… #21428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs rebase. |
…ock library The current version of the dmclock library does not handle operation cost well. Therefore cost should not be passed into the library when enqueuing operations; instead 0 should be passed in. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
ivancich
force-pushed
the
wip-fix-existing-mclock-cost
branch
from
a87d202
to
b110b14
Compare
|
retest this please. |
|
@ivancich could you provide more context w.r.t.
? is there any discussion (or anything) i can read to help me understand this assertion? |
|
@tchaikov I'm working on improving the library. See: ceph/dmclock#46 Furthermore, if you look at how cost is currently handled in the library, it's added to the reservation tag, which is very unlikely to be correct. (See: https://github.com/ceph/dmclock/blob/master/src/dmclock_server.h#L135) I would like to get this in for mimic. I should have addressed it earlier. |
this alone justifies the change. thanks for your explanation! |
tchaikov
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osd: remove cost from mclock op queues; cost not handled well in dmcock library
The current version of the dmclock library does not handle operation
cost well. Therefore cost should not be passed into the library when
enqueuing operations; instead 0 should be passed in.
Signed-off-by: J. Eric Ivancich ivancich@redhat.com