test/librbd: ensure OutOfOrder test has enough concurrent management ops #21436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
reviewed
Apr 17, 2018
| @@ -221,6 +221,9 @@ TEST_F(TestMockDeepCopyImageCopyRequest, SimpleImage) { | |||
| } | |||
|
|
|||
| TEST_F(TestMockDeepCopyImageCopyRequest, OutOfOrder) { | |||
| CephContext* cct = reinterpret_cast<CephContext*>(_rados.cct()); | |||
| REQUIRE(cct->_conf->get_val<int64_t>("rbd_concurrent_management_ops") >= 10); | |||
There was a problem hiding this comment.
Since I don't think we have any teuthology tests that would change this config parameter, this test would effectively never be run. Perhaps this test should store the current setting, update it, and then restore it prior to finishing.
Signed-off-by: Mykola Golub <mgolub@suse.com>
trociny
force-pushed
the
wip-test-out_of_order
branch
from
9ea2392
to
24481bb
Compare
trociny
changed the title
|
@dillaman updated |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test relies on large enough number of concurrent_management_ops.
Signed-off-by: Mykola Golub mgolub@suse.com