ceph-volume: Nits noticed while studying code #21455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Mick <dan.mick@redhat.com>
Signed-off-by: Dan Mick <dan.mick@redhat.com>
Signed-off-by: Dan Mick <dan.mick@redhat.com>
alfredodeza
reviewed
Apr 17, 2018
| @@ -217,7 +217,7 @@ def remove_vg(vg_name): | |||
| """ | |||
| Removes a volume group. | |||
| """ | |||
| fail_msg = "Unable to remove vg %s".format(vg_name) | |||
| fail_msg = "Unable to remove vg %s" % vg_name | |||
There was a problem hiding this comment.
woah, great catch! thanks for fixing these
|
jenkins test ceph-volume tox |
alfredodeza
approved these changes
Apr 17, 2018
liewegas
changed the title
|
Do we not want this in master? |
|
@dmick good catch, we were trying to get things moving for 12.2.5 and I missed out on having this merged. Thanks for the ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spelling/typos, unused function, small formatting bug